Skip to content

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Nov 21, 2023

Fixes #10285.
Fixes #10286.
Fixes #10289.
Fixes #10287.

This PR simply adds tests for the listed issues as they're already implemented so we can close them.

r? @blyxyas

changelog:none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 21, 2023
@blyxyas
Copy link
Member

blyxyas commented Nov 22, 2023

Could you please list where (in which PR) are they implemented? (ㅇㅅㅇ❀)

@GuillaumeGomez
Copy link
Member Author

You mean adding a comment in the UI tests for each of them or something else?

@blyxyas
Copy link
Member

blyxyas commented Nov 22, 2023

Thinking more about it, it doesn't matter

@GuillaumeGomez
Copy link
Member Author

As you wish. ;)

Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@blyxyas
Copy link
Member

blyxyas commented Nov 22, 2023

ฅ^•ﻌ•^ฅ

@bors
Copy link
Contributor

bors commented Nov 22, 2023

📌 Commit 2fa87fb has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 22, 2023

⌛ Testing commit 2fa87fb with merge b21c9d4...

@bors
Copy link
Contributor

bors commented Nov 22, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing b21c9d4 to master...

@bors bors merged commit b21c9d4 into rust-lang:master Nov 22, 2023
@GuillaumeGomez GuillaumeGomez deleted the add-more-transmute_ref_to_ref-tests branch November 22, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
4 participants